Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Elasticsearch_dsl support #557

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

amirbahador-hub
Copy link

Added Elasticsearch Support to FastAPI_Filter

In this pull request, I have introduced Elasticsearch support to the existing FastAPI_Filter library, which already provides search and filtering capabilities using SQLAlchemy and MongoDB. The addition of Elasticsearch support expands the range of options for users seeking efficient search functionality.

Currently, I haven't included tests and documentation for the Elasticsearch implementation. Before proceeding with these additions, I wanted to confirm whether you are interested in officially supporting Elasticsearch as part of the library.

For a practical demonstration of the Elasticsearch support, please refer to the example directory where I have provided sample code. I have also included a requirements.txt file and a docker-compose.yml file to simplify usage testing.

Please review this initial implementation and let me know if it aligns with your project's goals. If it does, I will proceed with adding comprehensive tests and documentation to ensure a seamless and well-documented contribution.

Copy link

netlify bot commented Feb 25, 2024

Deploy Preview for fastapi-filter ready!

Name Link
🔨 Latest commit f6b7550
🔍 Latest deploy log https://app.netlify.com/sites/fastapi-filter/deploys/65db6fae51602c0008669bac
😎 Deploy Preview https://deploy-preview-557--fastapi-filter.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Feb 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 38 lines in your changes are missing coverage. Please review.

Project coverage is 83.54%. Comparing base (e0f2fa8) to head (f6b7550).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##              main     #557       +/-   ##
============================================
- Coverage   100.00%   83.54%   -16.46%     
============================================
  Files            6        8        +2     
  Lines          193      231       +38     
============================================
  Hits           193      193               
- Misses           0       38       +38     
Files Coverage Δ
...stapi_filter/contrib/elasticsearch_dsl/__init__.py 0.00% <0.00%> (ø)
fastapi_filter/contrib/elasticsearch_dsl/filter.py 0.00% <0.00%> (ø)

@amirbahador-hub
Copy link
Author

@arthurio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant